Safe support for minting a Hypercert #483
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the outstanding renaming of main -> release and dev -> main this workflow will create a pull request every time a PR is merged into main, our then main development branch. I tested this workflow from a temporary branch called release-test. See an example PR that was created by this workflow here: hypercerts-org#478
On every PR against dev, main and release we want to run the following checks: * build the frontend w/o errors * run unit tests * run linter
The test was erroneously testing for the returning RPC URL to contain glif.io which was not the case. Since this provider is not specifically about Glif, it was renamed to FVMProvider.
…release-branch New GitHub actions
Change layout place of time and work scopes on the hypercert detail page
…rganize-time-or-work-and-scopes feat: reorganize time or work and scopes
The TODOs were actually part of a WIP commit, but were not thrown out as intended after finishing the implementation.
Since it's already available in the scope, why not use it?
This feels like a reusable component but it's not. Let's improve it!
Without this patch the user can only mint a Hypercert with their connected browser wallet. By passing the Safe address into the SDK function the Safe flow is invoked. The minting dialog now shows fewer steps and proposes a Safe transaction on successful signature.
|
@pheuberger is attempting to deploy a commit to the Hypercerts Foundation Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We first need to merge the Hypercerts SDK PR hypercerts-org/hypercerts-sdk#37 and then reference the newly published version here.
Until then this is kept in draft mode.